fix: use registry for runtime messaging #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
mhanberg
force-pushed
the
2023-07-20-workspace-registry
branch
from
f58aa39
to
ac89371
Compare
mhanberg
force-pushed
the
2023-07-19-styler
branch
from
7188497
to
a20cd04
Compare
mhanberg
force-pushed
the
2023-07-20-workspace-registry
branch
from
2dd230a
to
1f3cf4d
Compare
mhanberg
force-pushed
the
2023-07-19-styler
branch
from
a20cd04
to
c6cba98
Compare
mhanberg
force-pushed
the
2023-07-20-workspace-registry
branch
from
1f3cf4d
to
062f28c
Compare
This uses a registry to track the runtimes, so that if one crashes and is restarted, it will register itself with the registry and the LSP process doesn't need to track them itself. This also streamlines the logic for waiting for the the runtimes to be ready.
mhanberg
force-pushed
the
2023-07-20-workspace-registry
branch
from
062f28c
to
9c0d907
Compare
This was referenced Sep 30, 2023
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.